New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Nuclear Salt Processing Plant #607
Conversation
Enable the multi when loading Config handler for the multi More enabling Multi controller recipe Add necessary recipes to new, custom recipemap Add function to generate new recipes Declare item for the controller Define recipe map for the multi Render NEI page for the recipemap properly Change P output from 7 to 6 in recipe Spotless apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only code review, not balance review
...ileentities/machines/multi/processing/GregtechMetaTileEntity_NuclearSaltProcessingPlant.java
Outdated
Show resolved
Hide resolved
...ileentities/machines/multi/processing/GregtechMetaTileEntity_NuclearSaltProcessingPlant.java
Outdated
Show resolved
Hide resolved
...ileentities/machines/multi/processing/GregtechMetaTileEntity_NuclearSaltProcessingPlant.java
Outdated
Show resolved
Hide resolved
...ileentities/machines/multi/processing/GregtechMetaTileEntity_NuclearSaltProcessingPlant.java
Outdated
Show resolved
Hide resolved
...ileentities/machines/multi/processing/GregtechMetaTileEntity_NuclearSaltProcessingPlant.java
Show resolved
Hide resolved
.../java/gtPlusPlus/xmod/gregtech/registration/gregtech/GregtechNuclearSaltProcessingPlant.java
Outdated
Show resolved
Hide resolved
In terms of balance this sounds reasonable. LFTR is not exactly popular and this could bring some spice into it. Late IV recipe and numbers seem good. |
Warning: 2 uncommitted changes |
I think I made all the requested changes. |
Warning: 2 uncommitted changes |
Co-authored-by: GitHub GTNH Actions <>
Tested in the full pack, in the new 2.3.3 version
What is this?
This is a multiblock version of two singleblock machines (Reactor Processing Unit/Cold Trap) in the LFTR processing chain, which is a chain that uses fluorine and nuclear materials to generate power and some radioactive outputs. It combines the recipe maps of the two machines into one, and greatly facilitates the cumbersome automation of the singleblocks.
Why?
Both of the singleblocks have recipes that have filled cells on inputs and outputs, which creates an annoying, and honestly outdated automation, even for IV standards. This is the comparison between what the two automations are essentially like:
What exactly does it do?
It does the aforementioned recipes, with the chance for faster recipes (150% speed) and parallels that typical GT++ multis have. The structure uses Thermally Insulated Casings, which are HV-EV tier, and IV Machine Casings. The controller, however, uses the two IV singleblocks in its recipe, alongside Osmiridium, Ruridit and a ZPM circuit.
List of commit titles, for reference
Enable the multi when loadingConfig handler for the multi
More enabling
Multi controller recipe
Add necessary recipes to new, custom recipemap
Add function to generate new recipes
Declare item for the controller
Define recipe map for the multi
Render NEI page for the recipemap properly
Change P output from 7 to 6 in recipe
Spotless apply