Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Nuclear Salt Processing Plant #607

Merged
merged 7 commits into from May 1, 2023
Merged

Conversation

Steelux8
Copy link
Contributor

@Steelux8 Steelux8 commented Apr 23, 2023

Tested in the full pack, in the new 2.3.3 version

2023-04-23_23 37 46

What is this?

This is a multiblock version of two singleblock machines (Reactor Processing Unit/Cold Trap) in the LFTR processing chain, which is a chain that uses fluorine and nuclear materials to generate power and some radioactive outputs. It combines the recipe maps of the two machines into one, and greatly facilitates the cumbersome automation of the singleblocks.

Why?

Both of the singleblocks have recipes that have filled cells on inputs and outputs, which creates an annoying, and honestly outdated automation, even for IV standards. This is the comparison between what the two automations are essentially like:

2023-03-29_20 23 37

2023-04-23_18 01 15

What exactly does it do?

It does the aforementioned recipes, with the chance for faster recipes (150% speed) and parallels that typical GT++ multis have. The structure uses Thermally Insulated Casings, which are HV-EV tier, and IV Machine Casings. The controller, however, uses the two IV singleblocks in its recipe, alongside Osmiridium, Ruridit and a ZPM circuit.

2023-04-23_18 45 49

List of commit titles, for reference Enable the multi when loading

Config handler for the multi
More enabling
Multi controller recipe
Add necessary recipes to new, custom recipemap
Add function to generate new recipes
Declare item for the controller
Define recipe map for the multi
Render NEI page for the recipemap properly
Change P output from 7 to 6 in recipe
Spotless apply

Enable the multi when loading

Config handler for the multi

More enabling

Multi controller recipe

Add necessary recipes to new, custom recipemap

Add function to generate new recipes

Declare item for the controller

Define recipe map for the multi

Render NEI page for the recipemap properly

Change P output from 7 to 6 in recipe

Spotless apply
@Steelux8 Steelux8 marked this pull request as draft April 23, 2023 18:39
@Steelux8 Steelux8 marked this pull request as ready for review April 23, 2023 22:51
@Steelux8 Steelux8 requested review from a team April 23, 2023 22:51
Copy link
Contributor

@minecraft7771 minecraft7771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only code review, not balance review

@chochem
Copy link
Member

chochem commented Apr 26, 2023

In terms of balance this sounds reasonable. LFTR is not exactly popular and this could bring some spice into it. Late IV recipe and numbers seem good.

@github-actions
Copy link
Contributor

Warning: 2 uncommitted changes
#614

@Steelux8
Copy link
Contributor Author

I think I made all the requested changes.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Warning: 2 uncommitted changes
#615

Co-authored-by: GitHub GTNH Actions <>
@Dream-Master Dream-Master merged commit 7b1d087 into master May 1, 2023
1 check passed
@Dream-Master Dream-Master deleted the LFTR_Processing_Multis branch May 1, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants