Fixes several minor bugs #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can work properly should close #11190 in GTNewHorizons/GT-New-Horizons-Modpack
should close #13238 in GTNewHorizons GT-New-Horizons-Modpack
Added ghetto detection of when there is more than 1 element in a grouping, even when their symbols combined don't exceed three characters (like hydroxide)
last in a series of commits designed to resolve #11340 in GTNewHorizons/GT-New-Horizons-Modpack
Should close #11583 in GTNewHorizons/GT-New-Horizons-Modpack
Should close #11650 in GTNewHorizons/GT-New-Horizons-Modpack
should resolve #13317 in GTNewHorizons/GT-New-Horizons-Modpack, where the issues was mistakenly identified as the PSS accepting power when it is full. In fact, it does stop accepting power when full, but it is constantly leaking power into hatches. However it should be noted that unless the PSS has no hatches, it pays a tax each tick which will of course mean that it is almost never going to be filled up.
…b's file-view edit feature try it sometime and suffer! also spotless apply
…ull hatch" This reverts commit c20cc0b.
OneEyeMaker
approved these changes
May 16, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#11190 by letting the LV workbench store 2048 eu.
Closes GTNewHorizons/GT-New-Horizons-Modpack#13238 by adjusting the tooltip.
Closes GTNewHorizons/GT-New-Horizons-Modpack#11340 mostly by making the formula generator a little better at guessing when two or more elements are grouped together. Not every compound mentioned in the issue was in error due to this, but those were also fixed separately.
Closes GTNewHorizons/GT-New-Horizons-Modpack#11583 by actually implementing the stated functionality.
(no picture for this one, but I tested it and it does work correctly now)
Closes GTNewHorizons/GT-New-Horizons-Modpack#11650 by updating the tool tip and NEI pane.
Closes GTNewHorizons/GT-New-Horizons-Modpack#13317 by noting that there is no actual bug here, but that the PSS is very rarely ever full since it loses power every tick automatically. I added to the GUI to make this more clear to the user.
