Switch from hacking EnumHelper private apis to a java 9+ compatible reflection/unsafe approach #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glease
approved these changes
Jan 29, 2023
eigenraven
force-pushed
the
fix-j11-reflection
branch
from
cf734eb
to
d9e49fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make EnumHelper java 9+ compatible lwjgl3ify has to change its internals significantly, and doesn't preserve all the private methods as they don't all make sense to exist. This seems to be the only mod depending on them, so I include a j9+ compatible implementation of what it needs here. Also added clearing the enum cache after modifying it because it wasn't doing it before, which could lead to unpredictable runtime behavior.