Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement generic processing logic #176

Merged
merged 28 commits into from Jul 17, 2023
Merged

Implement generic processing logic #176

merged 28 commits into from Jul 17, 2023

Conversation

minecraft7771
Copy link

@minecraft7771 minecraft7771 commented Jul 14, 2023 •
edited

Needs https://github.com/GTNewHorizons/bartworks/pull/340

  • Migrated multis to GPL
  • Enable batch mode for PrAss
  • Remove TT-compat-interface which was deleted in favor of using exotic energy/long power base
  • !! Changes NA batch mode to not bypass 1 tick limiation as agreed in meta-dev. This single change is a balance change which is why admin approval is requested here !!

@minecraft7771 minecraft7771 requested review from a team July 14, 2023 15:01
@minecraft7771 minecraft7771 mentioned this pull request Jul 14, 2023
Merged
This was referenced Jul 14, 2023
Merged
Closed
miozune
miozune reviewed Jul 16, 2023
View reviewed changes
Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove GT_MetaTileEntity_LongPowerUsageBase in favor of GT_MetaTileEntity_ExtendedPowerMultiBlockBase? Looks mostly duplicate to me

src/main/java/goodgenerator/blocks/tileEntity/PreciseAssembler.java Outdated Show resolved Hide resolved
src/main/java/goodgenerator/blocks/tileEntity/FuelRefineFactory.java Outdated Show resolved Hide resolved
src/main/java/goodgenerator/blocks/tileEntity/NeutronActivator.java Outdated Show resolved Hide resolved
@minecraft7771 minecraft7771 mentioned this pull request Jul 16, 2023
Merged
@miozune
Copy link
Member

miozune commented Jul 17, 2023

Update BW to non-pre version before merge

@minecraft7771 minecraft7771 merged commit 328376f into master Jul 17, 2023
1 check passed
@minecraft7771 minecraft7771 deleted the feature/ImplementGenericProcessingLogic branch July 17, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miozune miozune miozune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@minecraft7771 @miozune