Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lighter water tweak #339

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Add lighter water tweak #339

merged 3 commits into from
Mar 1, 2024

Conversation

ah-OOG-ah
Copy link
Member

Reduces water's opacity from 3 to 1 like in modern versions. This tweak is off by default.

@Dream-Master Dream-Master requested review from a team and mitchej123 February 27, 2024 16:29
@Caedis
Copy link
Member

Caedis commented Feb 29, 2024

Can you add a screenshot of the differences?

@ah-OOG-ah
Copy link
Member Author

Before:
2024-02-29_08 52 12
After:
2024-02-29_08 53 16
1.16.5 vanilla (the change happened in 1.13 but I didn't have an instance for that):
2024-02-29_08 59 15
1.16.5 still appears brighter, but I believe that's due to smooth lighting changes - the actual light levels are the same.

@Caedis Caedis enabled auto-merge (squash) March 1, 2024 16:13
@Caedis Caedis merged commit fb329a0 into GTNewHorizons:master Mar 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caedis Caedis Caedis approved these changes

@mitchej123 mitchej123 Awaiting requested review from mitchej123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ah-OOG-ah @Caedis