Fix Thaumcraft leaves lag #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyfts
reviewed
May 1, 2024
src/main/java/com/mitchej123/hodgepodge/mixins/late/thaumcraft/MixinBlockMagicalLeaves.java
Outdated
Show resolved
Hide resolved
Glease
added a commit
to Glease/TC4Tweaks
that referenced
this pull request
May 2, 2024
|
If it is so hard to get right with mixin I'd try asm. See Glease/TC4Tweaks@c700d15 |
58 tasks
eigenraven
reviewed
May 3, 2024
| /** | ||
| * Old breakBlock() does not override the correct method. | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
Did you mean @Overwrite here?
There was a problem hiding this comment.
No. BlockMagicalLog does not actually override breakBlock() and I override it here
eigenraven
approved these changes
May 3, 2024
Dream-Master
pushed a commit
that referenced
this pull request
May 3, 2024
* fix * Overwrite -> Redirect (cherry picked from commit 18efce5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#16092. Should be tested with GTNewHorizons/Random-Things#6