fix incorrect use of weak reference #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilzinsel64
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GTNewHorizons/GT-New-Horizons-Modpack#13079
if unfortunate things can happen, it will happen. gc kick in after CachedPatternInventory is created, but before cache.inventory.get() has returned and cleared the WeakReference before it is ever used.
TBH it's highly questionable to use WeakReference as a cache. SoftReference combined with a expiration time or more complex custom cache clearing mechanism is a much better choice, or just simply guava cache, but I'm too lazy 馃槢