Prevent the Ore Finder Wand from imploding

[wlhlm]

Fixes GTNewHorizons/GT-New-Horizons-Modpack#13480

[github-actions]

Warning: 2 uncommitted changes
#14

[OneEyeMaker]

Current code doesn't solve issue completely, because there are keyboard shortcuts which allow to move items. More proper solution would be to implement something like locked slot and adding such slot like this.

[wlhlm]

My implementation is based on the GT++ backpack. That code has a few comments 1 2 3 regarding backpack self-storage, which I followed. You think this is broken in GT++ as well?

I have done some playtesting and it all worked as expected. Do you know some keybinds that might still allow transferring the wand into itself? Tried it with Inv and Mouse Tweaks.

[OneEyeMaker]

There is keyboard shortcut which allows to move any item to hotbar (IDK, is one added by vanilla or by tweaks mods).
Using this shortcut with current implementation allows move item away and destroy it.

Steps to reproduce (tested in survival, in creative NEI will dupe items):

1. Place ore finder on hotbar in N-th slot.
2. Open it's UI.
3. Hover mouse over any empty slot.
4. Press Ctrl+N (index of slot where ore finder is located, Ctrl+3, for example).
   Result: item is moved from original slot.
5. Drag and drop item away from UI window.
   Item is destroyed.

[OneEyeMaker]

After few more tests I found that item is destroyed only when NEI is enabled. But anyway I think that moving item from "locked" position isn't a desired behavior.

[wlhlm]

This actually vanilla functionality. net.minecraft.client.gui.inventory.GuiContainer#checkHotbarKeys. You don't have to hold Ctrl, just one of the hotbar shortcuts (1-9 by default).

[wlhlm]

OK, I have reworked the locked slot handling more akin to what Forestry does. This was very enlightening. Please have a look.

I'm gonna have to fix the GT++ backpack next (though probably nobody uses them 😛)

[OneEyeMaker]

Very good job!

Add just one method override to slot class for safety.

[wlhlm]

Committed (also updated the GT++ PR). Thank you.