Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put GTNH specific changes behind a dreamcraft check #19

Merged
merged 3 commits into from Mar 27, 2023

Conversation

mitchej123
Copy link

No description provided.

@mitchej123 mitchej123 requested review from glowredman and a team March 27, 2023 06:43
@EventHandler
public void init(FMLInitializationEvent event) {

// Register Network channels
MainProxy.createChannels();

// Gregtech New Horizons compat
isGTNH = Loader.isModLoaded("dreamcraft") && Loader.isModLoaded("gregtech");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why check for GT too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses some gt specific classes and would crash otherwise, so felt safer.

Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking for GT aswell is technically no necessary as it is a hard-dep of NHCore. Doesn't really matter though.

@Dream-Master Dream-Master merged commit ec0b739 into master Mar 27, 2023
2 checks passed
@mitchej123 mitchej123 deleted the non_gtnh_compat branch March 27, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants