Gunpowder #14
Merged
Gunpowder #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glowredman
requested changes
Dec 24, 2022
| @@ -1110,9 +1110,6 @@ public void addRecipes() { | |||
| // Clouds | |||
| GameRegistry.addRecipe(stackSingleCharcoal, "ccc", "ccc", "ccc", 'c', new ItemStack(cloud, 1, 2)); | |||
| GameRegistry.addRecipe(new ItemStack(plantItem, 1, 4), "cc", "cc", 'c', new ItemStack(cloud, 1, 3)); | |||
| GameRegistry.addRecipe( | |||
| new ShapedOreRecipe(new ItemStack(Items.gunpowder, 1, 0), "cc", "cc", 'c', "dustSulfur")); | |||
There was a problem hiding this comment.
Please don't remove the recipe. Just put it in a if (!Loader.isModLoaded("dreamcraft")) { } block instead.
| @@ -65,15 +65,12 @@ public void addInformation(ItemStack stack, EntityPlayer player, List list, bool | |||
| list.add(StatCollector.translateToLocal("tooltip.cotton")); | |||
| break; | |||
| case 4: | |||
| list.add(StatCollector.translateToLocal("tooltip.sulfur")); | |||
| list.add(StatCollector.translateToLocal("tooltip.fletching")); | ||
| break; | ||
| case 6: | ||
| case 5: |
There was a problem hiding this comment.
Just because you removed a case doesn't mean these need to be changed, this will cause wrong tooltips on the other items
| list.add(StatCollector.translateToLocal("tooltip.imp")); | ||
| break; | ||
| case 7: | ||
| case 6: |
|
Warning: 2 uncommitted changes |
glowredman
approved these changes
Dec 24, 2022
Co-authored-by: Martin Robertz <dream-master@gmx.net> Co-authored-by: GitHub GTNH Actions <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gunpowder recipe remove
remove tooltip