Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added research and recipe for Crimson Rites Book and Crimson Cult Banner #826

Merged
merged 7 commits into from
Apr 30, 2024

Conversation

Dyonovan
Copy link
Contributor

All recipes are based on the conversation @ GTNewHorizons/GT-New-Horizons-Modpack#14860

Researched is located on the Eldritch tab locked behind ELDRICHMAJOR (Eldrich Revelation). The banner recipe doesn't appear in the Thaumonomicon as there is no way to not compare by NBT so it only picks up the first recipe of the basic Thaumcraft banner. Recipe does show up in NEI.

@Dream-Master Dream-Master requested a review from a team March 20, 2024 18:56
@Dyonovan
Copy link
Contributor Author

Dyonovan commented Mar 20, 2024

Just realized it picked up my latest push. Didnt realize it did that. Do you want me to remove it?

@Dream-Master
Copy link
Member

Just realized it picked up my latest push. Didnt realize it did that. Do you want me to remove it?

what you mean ?

@LazyFleshWasTaken
Copy link

It added his pr for a broken spawner recipe.

@Dyonovan
Copy link
Contributor Author

Yea thats it. I was going to add a pull request eventually so if its ok just leave it in?

@chochem
Copy link
Member

chochem commented Mar 20, 2024

no. dont put unrelated stuff in.

why would we want a recipe for broken spawner anyway. that would reduce exploration even more.

@Dream-Master
Copy link
Member

@Dyonovan revert it and put it in a second pr. this have nothing todo with the first change.

…son Cult Banner to Thaumonomicon"

This reverts commit 8736864.
@Dyonovan
Copy link
Contributor Author

I have removed that commit

@Dream-Master
Copy link
Member

this commit had parts of the crimson rites pr guess you need re add it ? @Dyonovan

@Dyonovan
Copy link
Contributor Author

Yes. Doing it right now. just testing it

@Dyonovan
Copy link
Contributor Author

And Done.

Copy link
Contributor

@combusterf combusterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, merge if peaceful mode support is desired.

@chochem chochem added the ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Mar 21, 2024
@Dream-Master
Copy link
Member

@Dyonovan

@Dyonovan
Copy link
Contributor Author

I actually didn't do it for the peaceful run crowd, but for the sky block crowd. It's gated fairly high up the thaumcraft tree to be nice to have for all, but most people will be past that stage when it unlocks

@Dream-Master Dream-Master removed the ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Apr 28, 2024
@Dream-Master Dream-Master enabled auto-merge (squash) April 30, 2024 07:59
@Dream-Master Dream-Master merged commit 3a12097 into GTNewHorizons:master Apr 30, 2024
1 check passed
Dream-Master pushed a commit that referenced this pull request May 3, 2024
…ner (#826)

* Added research and recipe for Crimson Rites book

* Added recipe for the Crimson Cult Banner

* Fixed imports

* Added Broken Spawner recipe. Fixed not being able to add Crimson Cult Banner to Thaumonomicon

* Revert "Added Broken Spawner recipe. Fixed not being able to add Crimson Cult Banner to Thaumonomicon"

This reverts commit 8736864.

* Fixed not being able to add Crimson Cult Banner to the Thaumonomicon

---------

Co-authored-by: Dyonovan <dyonovan@dyonovan.com>
Co-authored-by: Martin Robertz <dream-master@gmx.net>
(cherry picked from commit 3a12097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants