-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added research and recipe for Crimson Rites Book and Crimson Cult Banner #826
Conversation
Just realized it picked up my latest push. Didnt realize it did that. Do you want me to remove it? |
what you mean ? |
It added his pr for a broken spawner recipe. |
Yea thats it. I was going to add a pull request eventually so if its ok just leave it in? |
no. dont put unrelated stuff in. why would we want a recipe for broken spawner anyway. that would reduce exploration even more. |
@Dyonovan revert it and put it in a second pr. this have nothing todo with the first change. |
…son Cult Banner to Thaumonomicon" This reverts commit 8736864.
I have removed that commit |
this commit had parts of the crimson rites pr guess you need re add it ? @Dyonovan |
Yes. Doing it right now. just testing it |
And Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, merge if peaceful mode support is desired.
I actually didn't do it for the peaceful run crowd, but for the sky block crowd. It's gated fairly high up the thaumcraft tree to be nice to have for all, but most people will be past that stage when it unlocks |
…ner (#826) * Added research and recipe for Crimson Rites book * Added recipe for the Crimson Cult Banner * Fixed imports * Added Broken Spawner recipe. Fixed not being able to add Crimson Cult Banner to Thaumonomicon * Revert "Added Broken Spawner recipe. Fixed not being able to add Crimson Cult Banner to Thaumonomicon" This reverts commit 8736864. * Fixed not being able to add Crimson Cult Banner to the Thaumonomicon --------- Co-authored-by: Dyonovan <dyonovan@dyonovan.com> Co-authored-by: Martin Robertz <dream-master@gmx.net> (cherry picked from commit 3a12097)
All recipes are based on the conversation @ GTNewHorizons/GT-New-Horizons-Modpack#14860
Researched is located on the Eldritch tab locked behind ELDRICHMAJOR (Eldrich Revelation). The banner recipe doesn't appear in the Thaumonomicon as there is no way to not compare by NBT so it only picks up the first recipe of the basic Thaumcraft banner. Recipe does show up in NEI.