New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a full recipe widget in item tooltips for bookmarked recipes #398
Conversation
Warning: 2 uncommitted changes |
Co-authored-by: GitHub GTNH Actions <>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems nice as a concept. I'd like to see it as a config option (which I didn't notice at a fairly quick glance) in case people are like "REE CHANGE", or those who use smaller UIs and it's annoying
It is a config option, I just need to test and fix the legacy handler offsets like rot13 said then it'll be done, |
@mitchej123 Please review again, I have done some more significant changes to fix the rendering order. It should be trivial, but take a look just in case I missed anything. |
I can still reproduce two of the issues I have mentioned above: Minecraft.1.7.10.2023-07-09.17-44-51.mp4
|
I'm not sure how to best solve the out-of-bounds drawing without redoing a lot of the vanilla tooltip rendering code, though something is clearly wrong because it should only switch to rendering the recipe above the tooltip when your mouse is below the midway point of the screen, which doesn't seem to be the case on your video? (looks like 1/4) I'll test the tinkers problem too, hopefully it's an easy fix |
Welp, that was a quick fix. Nice! |
Co-authored-by: Wilhelm Schuster <dev@rot13.io>
Show a full recipe widget showing missing items and a hint how to overlay the recipe using the keyboard in item tooltips for bookmarked items.