Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way catalyst info is loaded via API #434

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

miozune
Copy link
Member

@miozune miozune commented Oct 31, 2023

  • Move RecipeCatalysts#loadCatalystInfo to after IConfigureNEI load in order to allow registering catalysts via API inside IConfigureNEI
  • Move addition queue resolution to the beginning of loadCatalystInfo, while keeping removal queue at the end of config load
  • Don't overwrite catalysts loaded from API and IMC if catalyst config is loaded from jar

@miozune miozune requested a review from a team October 31, 2023 11:07
@miozune miozune force-pushed the feature/catalyst-api-dont-buffer branch from 5f3f214 to 0d2637d Compare October 31, 2023 11:11
@miozune miozune force-pushed the feature/catalyst-api-dont-buffer branch from 0d2637d to 3f9b327 Compare October 31, 2023 11:13
@miozune miozune merged commit bc7efcf into master Nov 8, 2023
1 check passed
@miozune miozune deleted the feature/catalyst-api-dont-buffer branch November 8, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants