Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NEI-Utilities #461

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

slprime
Copy link
Member

@slprime slprime commented Feb 21, 2024

History Panel (Full Item Panel Functionality)

Dotted Line

image

Background

image

Settings

image

Clipboard

image

P.S.
Issue GTNewHorizons/GT-New-Horizons-Modpack#15562

@Dream-Master Dream-Master requested a review from a team February 21, 2024 11:49
@slprime slprime requested a review from Caedis February 21, 2024 14:07
@Caedis
Copy link
Member

Caedis commented Feb 21, 2024

Should add a check if NEI-Utilities is loaded and maybe throw an error to stop loading?

@slprime
Copy link
Member Author

slprime commented Feb 21, 2024

Should add a check if NEI-Utilities is loaded and maybe throw an error to stop loading?

doesn't make sense.

@Caedis
Copy link
Member

Caedis commented Feb 21, 2024

What happens if a player has NEI-Utilities loaded as well?

@slprime
Copy link
Member Author

slprime commented Feb 21, 2024

What happens if a player has NEI-Utilities loaded as well?

image

@Caedis
Copy link
Member

Caedis commented Feb 21, 2024

Should prevent that

@slprime
Copy link
Member Author

slprime commented Feb 21, 2024

NEI cannot prevent this because nei-utilities patches ItemPanel

@Dream-Master Dream-Master merged commit f7ba34c into GTNewHorizons:master Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants