Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to OpenComputers 1.8.3 #104

Merged
merged 12 commits into from Jul 7, 2023
Merged

Update to OpenComputers 1.8.3 #104

merged 12 commits into from Jul 7, 2023

Conversation

asiekierka
Copy link

No description provided.

@Dream-Master Dream-Master requested review from repo-alt and a team July 7, 2023 18:58
@eigenraven
Copy link
Member

@asiekierka Looks like there's a missing dependency on JUnit or something similar:

compiling 2 Scala sources to /home/runner/work/OpenComputers/OpenComputers/build/classes/scala/test ...
Error:  /home/runner/work/OpenComputers/OpenComputers/src/test/scala/InternetFilteringRuleTest.scala:4:12: object junit is not a member of package org
Error:  /home/runner/work/OpenComputers/OpenComputers/src/test/scala/InternetFilteringRuleTest.scala:14:2: not found: type RunWith
Error:  /home/runner/work/OpenComputers/OpenComputers/src/test/scala/NetworkTest.scala:8:12: object junit is not a member of package org
Error:  /home/runner/work/OpenComputers/OpenComputers/src/test/scala/NetworkTest.scala:15:2: not found: type RunWith

@Dream-Master Dream-Master merged commit fc584f3 into GTNewHorizons:master Jul 7, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eigenraven eigenraven eigenraven approved these changes

@repo-alt repo-alt Awaiting requested review from repo-alt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@asiekierka @eigenraven @Dream-Master @Starlii10 @JLLeitschuh