Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic Bloodmoon #3

Merged
merged 1 commit into from Aug 25, 2023
Merged

Cyclic Bloodmoon #3

merged 1 commit into from Aug 25, 2023

Conversation

DrParadox7
Copy link
Contributor

@DrParadox7 DrParadox7 commented Aug 21, 2023

Add configuration to make Blood Moons cyclical (disabled by default).

Every X days (configurable) a blood moon will rise.
This works fine in conjunction with the current chance system but it would likely result in too frequent blood moons.

Add configuration to make Bloodmoons Cyclic (disabled by default)
@Dream-Master Dream-Master requested review from a team August 21, 2023 09:04
@Dream-Master
Copy link
Member

i would say lets add it.

@Dream-Master Dream-Master merged commit 41401fb into GTNewHorizons:master Aug 25, 2023
1 check passed
@Alastors
Copy link
Member

I don't see the point in this myself?

@Alastors
Copy link
Member

But as long as it's a config it's fine

@Dream-Master
Copy link
Member

its set to 0 so no changes so far. But if you want to change it you are now able to do so.

@Alastors
Copy link
Member

its set to 0 so no changes so far. But if you want to change it you are now able to do so.

Yeah but my thought is, this is a change that only really effects earlygame if it were ever turned past 0, like severe earlygame, and I really don't see any players saying "oh you know what this run needs? More time where I dig a pit and just hide in the ground while I AFK for 20 minutes"

@Dream-Master
Copy link
Member

@Alastors you you mean more player set the Blood moon to 0 to avaoid it ? Or what you maen ?

@eigenraven
Copy link
Member

I assume this PR is for DrParadox's pack, not really intended for GTNH - and the mob balance is different in different packs.

@Alastors
Copy link
Member

@Alastors you you mean more player set the Blood moon to 0 to avaoid it ? Or what you maen ?

I mean isn't there already a config to turn blood moons off?

My point was I don't ever see a time in which players would want to actually cause more blood moons to happen, because they're already just an annoying time to AFK for like 20 minutes instead of actual pack progress related stuff. Just another déterrant from people actually playing the pack.

But yeah like Raven said it's probably not meant for our pack so /shrug I guess

@Dream-Master
Copy link
Member

this config give us the change or others play the pack say ok every 7 days a blood moon occurs for every x days? If it is set to 0 nothing happen it use the chance value right ?

@Dream-Master
Copy link
Member

@Alastors you you mean more player set the Blood moon to 0 to avaoid it ? Or what you maen ?

I mean isn't there already a config to turn blood moons off?

My point was I don't ever see a time in which players would want to actually cause more blood moons to happen, because they're already just an annoying time to AFK for like 20 minutes instead of actual pack progress related stuff. Just another déterrant from people actually playing the pack.

But yeah like Raven said it's probably not meant for our pack so /shrug I guess

yes there is an option to turn it off

@Alastors
Copy link
Member

this config give us the change or others play the pack say ok every 7 days a blood moon occurs for every x days? If it is set to 0 nothing happen it use the chance value right ?

It says you can use both together in the ticket itself

@Dream-Master
Copy link
Member

yea i just ask the dev and get this confirmed. So this pr have 0 downside for GTNH

@Alastors
Copy link
Member

yea i just ask the dev and get this confirmed. So this pr have 0 downside for GTNH

Sure, I suppose, that's why I'm not personally against it, I just don't much see the point (except now with Raven's thought)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants