Message discriminators *MUST* exist on the channel on both sides if t… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here is more than one message or the one message does not use ID 0, and this mod has two message, meaning when a MessageTexture gets sent from the server then it gets a discriminant of 0, meaning the client then deserializes it as MessageExplosion, which "most" of the time it will just harmless tell the client explosions are happening randomly around the world where they are not, but sometimes it crashes due to not enough data in the packet stream to deserialize, registering the messages on both server and client fixes it
|
Is this the cause of the OOM exception in MessageExplosion.fromBytes()? |
eigenraven
approved these changes
Apr 8, 2023
Oh sorry, didn't see this message @dvdmandt, yes that looks like the same error that I got because of this issue, so this probably fixes that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message discriminators MUST exist on the channel on both sides if there is more than one message or the one message does not use ID 0, and this mod has two messages, meaning when a MessageTexture gets sent from the server then it gets a discriminant of 0, meaning the client then deserializes it as MessageExplosion, which "most" of the time it will just harmless tell the client explosions are happening randomly around the world where they are not, but sometimes it crashes due to not enough data in the packet stream to deserialize, registering the messages on both server and client fixes it.