Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC Aspects not showing up on bookmarks correctly fix. #21

Merged
merged 5 commits into from May 10, 2023

Conversation

Cardinalstars
Copy link

@Cardinalstars Cardinalstars commented May 7, 2023

Fixed bookmarks not displaying properly due to some weird ways of doing stuff in tcneiadditions, now bookmarks display the correct aspect amount.

One small caveat is that if the game crashes or forcibly closes you lose just your aspects in the bookmarks page. I'm not sure what is going on with that, but that was already happening before I made changes.

(Ignore the commit saying one-line fix, I was young and Naive then)

OLD:
image

NEW:
image

@Dream-Master Dream-Master requested review from a team May 7, 2023 19:03
Copy link
Member

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some minor duplicated code, but nothing too egregious, looks fine to me, and it seems like he's tested this in the pack and it's currently working, so looks fine to me.

@Cardinalstars
Copy link
Author

There's some minor duplicated code, but nothing too egregious, looks fine to me, and it seems like he's tested this in the pack and it's currently working, so looks fine to me.

Thing is the functions that do the aspect drawing and the aspect ingredient population need to be similar but not the same for each recipe type. I could do a helper util somewhere, but I genuinely believe this is best for readability. I can't touch anything in the parent class since ya know... arr... otherwise yes I would've made something to homogenize them. If anyone wants me to make a helper class I could, but that realistically would just be moving the code more or less.

@Cardinalstars
Copy link
Author

I meant to have another commit on this to reduce the amount of code and help clutter. Do not merge this yet as I forgot to push it and I am at work.

@chochem chochem marked this pull request as draft May 9, 2023 14:17
@Cardinalstars Cardinalstars marked this pull request as ready for review May 9, 2023 23:04
@Dream-Master Dream-Master merged commit a2f7577 into GTNewHorizons:master May 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants