Fix terra primordial regen

[chochem]

fixes (and thus nerfs) the op regen that terra affinity primordial armor provides.

It was giving (upto) instant health 5 but over time for some reason, which then applies that every tick resulting in hundreds of health per second. I replaced that with a buffed up regen effect ranging all above the usual potion range so that terra is still good. Specifically from level III with 1 item to the maximum vanilla code can handle of VI with 4 items. That means with all 4 items having terra affinity the player still regens 20 health per second (!) for 10 seconds after being hit. Note that regen scales exponentially with effect level, see https://minecraft.fandom.com/wiki/Regeneration. If that is considered too strong I can tone it down a bit but I think it would be nice to keep something strong here.

fixes GTNewHorizons/GT-New-Horizons-Modpack#10656 and fixes GTNewHorizons/GT-New-Horizons-Modpack#8202

I also tested triggering the regen VI in the full game and it works as advertised

[Sheodar]

What a sense to use this armor on IV if that will not give this heal? It is PBI already, so it is not early game, and on this stage we can use other armors and invul sources. Boots already useless, because it doesn't give any Voidwalker's bonuses (no speed, no work with Voidwalker's sash). And toggler for aspect still is pain, becaues we need call this ring multiply times if u want to turn on prev aspect. Which is sense if u can just skip in and use something better (like ichorium).

[Sheodar]

I'd prefer to add PBI component for boots crafting too, because it can be crafted earlier then other 3 parts and terra boots on this stages can be OP

[Alastors]

What a sense to use this armor on IV if that will not give this heal? It is PBI already, so it is not early game, and on this stage we can use other armors and invul sources. Boots already useless, because it doesn't give any Voidwalker's bonuses (no speed, no work with Voidwalker's sash). And toggler for aspect still is pain, becaues we need call this ring multiply times if u want to turn on prev aspect. Which is sense if u can just skip in and use something better (like ichorium).

It’ll still heal my guy, just 20 hearts a second instead of being instant

[chochem]

you confuse me. In the other PR you (incorrectly) claimed that primoridial is less than 1 health/s and now you think 20 is not enough?

[Sheodar]

What a sense to use this armor on IV if that will not give this heal? It is PBI already, so it is not early game, and on this stage we can use other armors and invul sources. Boots already useless, because it doesn't give any Voidwalker's bonuses (no speed, no work with Voidwalker's sash). And toggler for aspect still is pain, becaues we need call this ring multiply times if u want to turn on prev aspect. Which is sense if u can just skip in and use something better (like ichorium).

It’ll still heal my guy, just 20 hearts a second instead of being instant

Exactly. So there is only one totaly we have one result of this change - user need toggle each peace of armor each time when need a heal and when to need a heal. So is it the removal of QoL? There is not easy way to swap aspects, need unequip armor - click - click ... click - click x4 repeat

[Sheodar]

you confuse me. In the other PR you (incorrectly) claimed that primoridial is less than 1 health/s and now you think 20 is not enough?

I fixed armor REPAIRING (warp modifier on items should repair this items). I didn't talk about heal.

[chochem]

ah, so when you say regen you mean repair. well that clears up my confusion in the other PR, thanks! Anyway, 20/s is plenty and more than any other option available for the player that I am aware of.

[Sheodar]

ah, so when you say regen you mean repair. well that clears up my confusion in the other PR, thanks! Anyway, 20/s is plenty and more than any other option available for the player that I am aware of.

I talk about this just above. It's still a lot, yes. But now the player has to toggle 4 armor parts, instead of one, to enable/disable terra. Which sense to nerf it if it is still good heal? It is just extra stress when u need toggle full armor set.

[chochem]

because its a massive BM exploit. see attached ticket

[Sheodar]

Player can self-damage 20hearts/sec max (each tick). So it is still a possible way to get LP. And remember, it is still MANUALLY work. That can be automatted still. And you cannot get this armor on HV or EV when u can use rituals. So u open auto-LP first, and this armor after only.

[chochem]

20hearts/sec max (each tick)

that doesnt even make sense.

And yes indeed it will still be a great way to get LP with this change, that's what we are trying to tell you. Just wont be as broken as it is currently.

[Sheodar]

20hearts/sec max (each tick)

that doesnt even make sense.

And yes indeed it will still be a great way to get LP with this change, that's what we are trying to tell you. Just wont be as broken as it is currently.

I.e. it doesn't change anything, it just makes the game more uncomfortable. Weird logic, but okay.

[chochem]

nah thats not correct. you can sacrifice much faster, see the ticket.

[Sheodar]

Would be cool to have something this if players should toggle this armor tons times per session, but it is UI for minecraft, meh

[Sheodar]

nah thats not correct. you can sacrifice much faster, see the ticket.

How u can do something faster then 1 game tick? I'm sure i don't know all, just interesting

[Alastors]

Would be cool to have something this if players should toggle this armor tons times per session, but it is UI for minecraft, meh

Fuck no

[Sheodar]

Would be cool to have something this if players should toggle this armor tons times per session, but it is UI for minecraft, meh

Fuck no

I know :kekw:

[chochem]

nah thats not correct. you can sacrifice much faster, see the ticket.

How u can do something faster then 1 game tick? I'm sure i don't know all, just interesting

Ritual of the feathered knife with WA (plus all the rest). as I said, just look at the ticket. ;)

and while UI improvements might be desirable that is not the purpose of this PR.

[Sheodar]

nah thats not correct. you can sacrifice much faster, see the ticket.

How u can do something faster then 1 game tick? I'm sure i don't know all, just interesting

Ritual of the feathered knife with WA (plus all the rest). as I said, just look at the ticket. ;)

and while UI improvements might be desirable that is not the purpose of this PR.

I checked it several times. And for the third time, you can't do anything more than 20 times per second. LITERALLY. It's physically impossible. Even the ticket specifies a 50ms delay (20 times per second. Second have 1000ms). So this change literally forces the player to toggle all armor pieces, instead of just one piece.

[Sheodar]

The other way - add some config for this armor. Not the heal effect only. Other effects too. So players and admins can control this not cheap, but quite a complex armor.

[chochem]

I checked it several times. And for the third time, you can't do anything more than 20 times per second. LITERALLY. It's physically impossible. Even the ticket specifies a 50ms delay (20 times per second. Second have 1000ms). So this change literally forces the player to toggle all armor pieces, instead of just one piece.

I am sorry but this is really getting offtopic. you can use more than regen VI even if you yourself cant manage it in three tries (I am able to beat that on my end just fine). This is not a help chat for things that can be seen as exploits.

I also have no interest in GUI work myself and dont think that every number in the game needs a config.

[Alastors]

I gotta agree with chochom here, this just needs to happen

[Alastors]

Also yeah GUI work fuckin sucks, I can personally attest to that

[Sheodar]

I am sorry but this is really getting offtopic. you can use more than regen VI even if you yourself cant manage it in three tries. This is not a help chat for things that can be seen as exploits.

I also have no interest in GUI work myself and dont think that every number in the game needs a config.

It is not offtop. I'm just trying to explain why this fix doesn't have sense in this case. I'm not defending terra effect. It is strong, yes.

But if we are talking about nerf and LP farm only we need to reduce heal effect for players cannot use knife each game tick. Because in current values they STILL can do it. If patch change nothing - for what it? Did u want to fix LP farm? It is still possible.

Personally for me it is fine, because u have auto ways to get LP on IV tier. There is only one error - boots doesn't contain PBI in craft and can be crafted before IV. And it is just one alternative how to farm it.

But if we will kill this heal, need resolve one other question - for what need to craft this armor? Boots slot already blocked, because primordial boots doesn't have voidwalkers bonuses and actives (belt). Don't forget about people which love magic part of modpack too.

But yeah, i think we already discussed all things about this. Continues will be just a repeateable. Maybe this post will clarify what I was trying to explain above.

[chochem]

I am just gonna ignore the part were you repeat the incorrect stuff.

the boots naturally dont use shadow fortress, hence the different reqs. but having just one item wont be that great now anyway. And alastor has larger plans for a big outlet store of boots. not gonna start changing recipes while that is ongoing for sure (if at all).

[Alastors]

I am just gonna ignore the part were you repeat the incorrect stuff.

the boots naturally dont use shadow fortress, hence the different reqs. but having just one item wont be that great now anyway. And alastor has larger plans for a big outlet store of boots. not gonna start changing recipes while that is ongoing for sure (if at all).

Yeah Thaumic boots is basically finished, I just have the lore and the recipes I'll have to handle in coremod left

Well that and the new boots that are still waiting for textures but that's whatever