Prevent custom diagrams from overriding NEI tab scrolling #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneEyeMaker
approved these changes
Jun 19, 2023
D-Cysteine
added a commit
to D-Cysteine/nei-custom-diagram
that referenced
this pull request
Apr 22, 2024
Changes: * Added chemical bath and mixer additional recipes to GT5 Ore Processing diagram * Fixed clipping on left edge of NBT Viewer diagram * Uncommented Transcendent Plasma Mixer in GT5 Recipe Debugger diagram * Updated Gradle wrapper to 8.7 * Overhauled build script and updated to use RetroFuturaGradle * Updated and cleaned up dependencies Merged commits from downstream: * GTNewHorizons@916d2b3 * GTNewHorizons#29 * GTNewHorizons#28 * GTNewHorizons#27 * GTNewHorizons#26 * GTNewHorizons#25 Co-Authored-By: Raven Szewczyk <git@eigenraven.me> Co-Authored-By: Wilhelm Schuster <1928113+wlhlm@users.noreply.github.com> Co-Authored-By: miozune <40035906+miozune@users.noreply.github.com> Co-Authored-By: Martin Robertz <dream-master@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GTNewHorizons/NotEnoughItems#379 you can use the scroll wheel over the NEI tab bar to switch between recipe handlers. NEI Custom Diagrams overwrote that behavior since it didn't always check whether the mouse is actually over the diagram while scrolling. This reworks the logic to fix that.