Gpl to mit #76
Gpl to mit #76
Conversation
… version required. Modification of documentation accordingly
|
Some parts are on the website, so not in this repos, so I'll comment as discussion: VincentRouvreau: cf. GUDHI/GUDHI.github.io#3 |
|
Maybe mention in the licensing page that we write "Copyright: MIT (GPL v3)" in the package list for exactly the situation described: our code is MIT, but there is a dependency on GPL code, so for practical purposes for a user it is as if this package was GPL. VincentRouvreau: cf. GUDHI/GUDHI.github.io#3 |
|
homsimpl: removing the binary is sensible, not just for the license. |
src/Contraction/include/gudhi/Contraction/CGAL_queue/Modifiable_priority_queue.h
Show resolved
Hide resolved
This shall be done in master.
…ty_queue.h which is LGPL, not GPL
…ll be displayed when not installed.
|
@mglisse : thanks for the review. I fixed all the points, tell me if you are ok with it. |
|
Fixes #35 |
src/GudhUI/model/Model.h
Outdated
| @@ -307,9 +307,15 @@ class Model { | |||
| private: | |||
| void run_chomp() { | |||
| save_complex_in_file_for_chomp(); | |||
| std::cout << "POUET" << std::endl; | |||
There was a problem hiding this comment.
oops, sorry : VincentRouvreau@0a4ece4
src/GudhUI/model/Model.h
Outdated
| return; | ||
| } | ||
| returnValue = system("homsimpl chomp.sim"); | ||
| std::cout << "CHOMP returns " << returnValue << std::endl; |
There was a problem hiding this comment.
I think it might be enough to test the returnValue of system("homsimpl chomp.sim"), and if it is non-zero, explain that homsimpl (from CHOMP) failed, which could happen in particular if it isn't installed or in the PATH. I am a bit wary of using which, but maybe it has advantages?
There was a problem hiding this comment.
From GPL v3 license to MIT.
Licensing documentation from a branch gpl_to_mit in https://github.com/GUDHI/GUDHI.github.io
Python documentation
C++ documentation
Fixes #35