Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI refreshes too often #15

Open
alex285 opened this issue Feb 2, 2018 · 12 comments
Open

UI refreshes too often #15

alex285 opened this issue Feb 2, 2018 · 12 comments
Labels
enhancement New feature or request

Comments

@alex285
Copy link

alex285 commented Feb 2, 2018

I guess you're aware of most UI issues, but here is one you might have missed. When you download wallpapers, those might have very long names ..as you can see on screenshot

screenshot from 2018-02-03 01-42-58

Two more issues here is that

  1. The selection gets the full height
  2. When you remove a favorite (or when you add one), the view is refreshing all the items, while there is also a lock
@GabMus GabMus added the UI bug label Feb 3, 2018
@GabMus
Copy link
Owner

GabMus commented Feb 5, 2018

  1. Tried to solve that, had no luck. This is pretty low in priority tho, will try to fix it when I can.

  2. Yeah, the UI refresh is one of the weakest points of this app. Will have to make a subclass of FlowBoxItem and do some wizardry to make it a little better. It's in the works tho.

GabMus added a commit that referenced this issue Feb 5, 2018
@GabMus
Copy link
Owner

GabMus commented Feb 5, 2018

Tried to fix the label issue, and mitigate in some way the ui refresh slowness. Still, removing the locks causes problems in most cases, so I think they'll be there for a while, until I figure out a better way to populate/update the flowboxes.

Here's a flatpak that you can test

hydrapaper-246c002.zip

@alex285
Copy link
Author

alex285 commented Feb 6, 2018

@GabMus thank you! the title is fine now!

@GabMus
Copy link
Owner

GabMus commented Feb 6, 2018

Fixed "selection gets full height" in c050e78 .

Here you can test it.

hydrapaper-c050e78.zip

@GabMus GabMus changed the title Popover cannot handle long filenames UI refreshes too often Feb 6, 2018
@alex285
Copy link
Author

alex285 commented Feb 6, 2018

@GabMus question: why you dont just update the flatpak repo, since you obviously fix things?

@GabMus
Copy link
Owner

GabMus commented Feb 6, 2018

You mean the released package? There are some things I'm still not convinced about. Want to make a bigger release.

@GabMus GabMus added enhancement New feature or request and removed UI bug labels Feb 6, 2018
@GabMus
Copy link
Owner

GabMus commented Feb 8, 2018

reduced ui refreses in 80b085c

@GabMus
Copy link
Owner

GabMus commented Feb 9, 2018

did some general improvements to reduce UI refresh, here's a new flatpak:

hydrapaper-1.1.3-28-gd1622bf.zip

@alex285
Copy link
Author

alex285 commented Feb 9, 2018

@GabMus where the "Favorites" view has gone? i mean it is gone :)

@GabMus
Copy link
Owner

GabMus commented Feb 9, 2018

It goes away if you don't have any favorites. Add some and you will see it appear in the top stack switcher

@GabMus
Copy link
Owner

GabMus commented Feb 9, 2018

Did a little visual fix, here's an updated flatpak:

hydrapaper-1.1.3-29-g44c0181.zip

@GabMus
Copy link
Owner

GabMus commented Feb 9, 2018

Fixed some issues, new flatpak:
hydrapaper-1.1.3-30-g2cf4fe3.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants