Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read statusDetail instead of statusList #44

Merged
merged 1 commit into from
Nov 16, 2019

Conversation

exKAZUu
Copy link
Contributor

@exKAZUu exKAZUu commented Oct 1, 2019

Pull Request

Related issue

#41

Description

This PR fixes #41 by reading the correct property statusDetail instead of statusList.

Why

The correct property name seems statusDetail described in https://developer.chrome.com/webstore/webstore_api/items/publish

How

I've read https://developer.chrome.com/webstore/webstore_api/items/publish and corrected the property name.

Screenshots

[4:39:16 AM] [semantic-release] › ✖  An error occurred while running semantic-release: { TypeError: Cannot read property '0' of undefined
    at publish (/home/circleci/project/node_modules/semantic-release-chrome/dist/publish.js:60:44)
    at process._tickCallback (internal/process/next_tick.js:68:7) pluginName: 'semantic-release-chrome' }
{ TypeError: Cannot read property '0' of undefined
    at publish (/home/circleci/project/node_modules/semantic-release-chrome/dist/publish.js:60:44)
    at process._tickCallback (internal/process/next_tick.js:68:7) pluginName: 'semantic-release-chrome' }error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

How has this been tested

Sorry, I don't know how to test this package. If needed, please help me to test this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Documentation
  • Ready to be merged
  • My code follows the code style of this project (run npm run ci to be sure).
  • I have read the CONTRIBUTING document.

@GabeDuarteM
Copy link
Owner

Thank you for the PR! Code-wise it looks good to me, I just didn't merge it yet because I wanted to test it first, and to do that I'd like to release a dummy extension. Unfortunately, I didn't find the time yet to do it.

By any chance, have you tried releasing any extension with these changes?

@exKAZUu
Copy link
Contributor Author

exKAZUu commented Oct 10, 2019

Okay. Unfortunately, I didn't and I have no plan most recently, but I definitely will do that at some time.

@exKAZUu
Copy link
Contributor Author

exKAZUu commented Oct 15, 2019

@GabrielDuarteM I now confirm my change fixes the issue (though I find another issue #46).
I successfully uploaded a new version of my extension (https://github.com/WillBooster/plantuml-visualizer) by using semantic-release-chrome with this patch (https://github.com/WillBooster/plantuml-visualizer/blob/master/package.json#L60).

@exKAZUu exKAZUu mentioned this pull request Nov 10, 2019
7 tasks
@GabeDuarteM GabeDuarteM merged commit aa6bba6 into GabeDuarteM:master Nov 16, 2019
@GabeDuarteM
Copy link
Owner

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@exKAZUu exKAZUu deleted the patch-1 branch January 31, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release failing but extension got updated
2 participants