Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the instance for Backwards to fix #8 #10

Closed
wants to merge 1 commit into from

Conversation

josefs
Copy link

@josefs josefs commented Jan 6, 2014

Importing Control.Applicative.Backwards means that we have to depend on
transformers version 0.3 or higher. This change lets us keep the more lax
constraint in transformers.

Importing Control.Applicative.Backwards means that we have to depend on
transformers version 0.3 or higher. This change lets us keep the more lax
constraint in transformers.
@pthariensflame
Copy link

I don't think this instance should be removed entirely; CPP exists for a reason. :)

@Gabriella439
Copy link
Owner

Hmm. @pthariensflame has a point. I will write up a backwards compatible patch that keeps the Backwards instances.

@Gabriella439
Copy link
Owner

So I fixed this in version 1.0.2. There are now ifdef guards around all the Control.Applicative.Backwards and Control.Applicative.Lift code that will remove them for transformers versions less than 0.3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants