Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul of contrast code #32

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Overhaul of contrast code #32

merged 4 commits into from
Jul 28, 2021

Commits on Apr 30, 2021

  1. Reimplement .getContrastInit 

    The new implementation does not actually fit a dummy model in order to
extract the fixed effect names, but rather copies the logic in
lme4::lFormula to construct the same fixed effects model matrix that
lmer will use and return the column names.
    @DarwinAwardWinner
    DarwinAwardWinner committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    0029c86 View commit details
    Browse the repository at this point in the history

  2. Reimplement .getAllUniContrasts 

    The new implementation simply uses diag to generate the univariate
contrast matrix, and then sets the dimnames appropriately.
    @DarwinAwardWinner
    DarwinAwardWinner committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    3a3ff6c View commit details
    Browse the repository at this point in the history

  3. Reimplement isRunableFormula 

    Since .getContrastInit no longer throws errors on rank deficiency,
isRunableFormula needs to check this on its own.
    @DarwinAwardWinner
    DarwinAwardWinner committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    548cb72 View commit details
    Browse the repository at this point in the history

  4. Implement makeContrastsDream 

    This is the dream equivalent of limma::makeContrasts, and should
support all the same syntax for arbitrarily complex contrasts
involving any number of coefficients.
    Ryan C. Thompson committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    20c0284 View commit details
    Browse the repository at this point in the history