Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use EnumSet in MachineBlockEntity for valid connection directions #483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dfsek
Copy link

@dfsek dfsek commented Jul 26, 2022

Currently, MachineBlockEntity#validConnections uses an ArrayList for storing connection directions, this is significantly slower than using EnumSet, for contains operations. this performance difference manifests when large networks transfer energy. No accesses of this value rely on order of elements, so changing the collection implementation used produces no differences in behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant