Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Fabric 0.15.10, fixes server crash for 1.19.2. #586

Open
wants to merge 2 commits into
base: 1.19
Choose a base branch
from

Conversation

Slayer5934
Copy link

No description provided.

@EggTime
Copy link

EggTime commented Apr 26, 2024

Heyo, thanks for the fix for fabric 0.15.10! However, I'm getting a server crash with this version when opening a GUI
Description:

Crashing when opening a gui from a machine (i.e., coal generator, solid infuser, etc..).
This only happens on a server, not a single player world.

Steps to Reproduce:

Open coal generator, solid infuser, etc.. with a GUI

Technical Information:

Minecraft: 1.19.2
Fabric API: 0.15.10
Server Launcher Jar: fabric-server-mc.1.19.2-loader.0.15.10-launcher.1.0.1.jar
Industrial Revolution: indrev-1.15.2-BETA-fab15hotfix.jar
Modpack: FTB Legend of the Eyes

Crashlog: https://pastebin.com/raw/1ReurQnp

@Slayer5934
Copy link
Author

Slayer5934 commented Apr 26, 2024

Heyo, thanks for the fix for fabric 0.15.10! However, I'm getting a server crash with this version when opening a GUI Description:

Crashing when opening a gui from a machine (i.e., coal generator, solid infuser, etc..). This only happens on a server, not a single player world.

Steps to Reproduce:

Open coal generator, solid infuser, etc.. with a GUI

Technical Information:

Minecraft: 1.19.2 Fabric API: 0.15.10 Server Launcher Jar: fabric-server-mc.1.19.2-loader.0.15.10-launcher.1.0.1.jar Industrial Revolution: indrev-1.15.2-BETA-fab15hotfix.jar Modpack: FTB Legend of the Eyes

Crashlog: https://pastebin.com/raw/1ReurQnp

Hello, yes LibGui fork is also required to completely fix the issue.
https://github.com/TeamChikken/LibGui-CHKNFork-1.19.2/releases/tag/1.19.2
Both of the mods would need to accept the proposed fixes (or fix them) for it to not crash, for now put but the fixed IndRev version and LibGui version in the mods folder.

@EggTime
Copy link

EggTime commented Apr 28, 2024

Heyo, thanks for the fix for fabric 0.15.10! However, I'm getting a server crash with this version when opening a GUI Description:
Crashing when opening a gui from a machine (i.e., coal generator, solid infuser, etc..). This only happens on a server, not a single player world.
Steps to Reproduce:
Open coal generator, solid infuser, etc.. with a GUI
Technical Information:
Minecraft: 1.19.2 Fabric API: 0.15.10 Server Launcher Jar: fabric-server-mc.1.19.2-loader.0.15.10-launcher.1.0.1.jar Industrial Revolution: indrev-1.15.2-BETA-fab15hotfix.jar Modpack: FTB Legend of the Eyes
Crashlog: https://pastebin.com/raw/1ReurQnp

Hello, yes LibGui fork is also required to completely fix the issue. https://github.com/TeamChikken/LibGui-CHKNFork-1.19.2/releases/tag/1.19.2 Both of the mods would need to accept the proposed fixes (or fix them) for it to not crash, for now put but the fixed IndRev version and LibGui version in the mods folder.

Fix works! except crashes with the Modular Workbench

Crash Report: https://pastebin.com/raw/ZLK8qr98

I saw pull request 583 fixes it, maybe see if merging the branches works?

@Slayer5934
Copy link
Author

Slayer5934 commented Apr 29, 2024

That fix is already applied, something else is going wrong and ill have to look into it
Edit: Could you give information on how it crashes? I tested in my modpack and it doesn't seem to crash when opening the menu

@EggTime
Copy link

EggTime commented Apr 29, 2024

That fix is already applied, something else is going wrong and ill have to look into it Edit: Could you give information on how it crashes? I tested in my modpack and it doesn't seem to crash when opening the menu

Heyo, It would just happen when I right clicked the workbench. I'm using the FTB Legend of the Eyes modpack. I did add a couple other mods that only deal with worldgen (but nothing with GUIs, so I doubt they are the issue).

Here's the crashlog for when I just did it again. https://pastebin.com/raw/Xh3M60z5

@wyatt-herkamp
Copy link

wyatt-herkamp commented May 2, 2024

    repositories {
        maven {
            url "https://maven.cafeteria.dev/releases"
            credentials {
                if (project.hasProperty("mcdUsername") && project.hasProperty("mcdPassword")) {
                    username = project.property("mcdUsername")
                    password = project.property("mcdPassword")
                }
            }
            authentication {
                basic(BasicAuthentication)
            }
        }
    }

You can use this to prevent the Gradle error about missing properties while keeping the ability for the owner to publish to that repository.

@Slayer5934
Copy link
Author

That fix is already applied, something else is going wrong and ill have to look into it Edit: Could you give information on how it crashes? I tested in my modpack and it doesn't seem to crash when opening the menu

Heyo, It would just happen when I right clicked the workbench. I'm using the FTB Legend of the Eyes modpack. I did add a couple other mods that only deal with worldgen (but nothing with GUIs, so I doubt they are the issue).

Here's the crashlog for when I just did it again. https://pastebin.com/raw/Xh3M60z5

Hey this should be fixed now, to be honest the mod needs some more serious work on it, but the crashes for modular bench and rancher are fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants