Initial conversion to ExceptT. #34
Conversation
|
This looks great! Is there any outstanding work that can be done to assist in getting this merged/released? |
| @@ -59,57 +62,72 @@ import Data.Maybe (fromMaybe) | |||
| import System.Exit (ExitCode) | |||
| import System.IO (hPutStr, hPutStrLn, stderr) | |||
|
|
|||
| exceptT :: Monad m => (a -> m c) -> (b -> m c) -> ExceptT a m b -> m c | |||
There was a problem hiding this comment.
Can you add the following documentation to these three functions:
-- | Fold an `ExceptT` by providing one continuation for each constructor
exceptT :: ...
-- | Transform the left and right value
bimapExceptT :: ...
-- | Upgrade an `Either` to an `ExceptT`
hoistEither :: ...
Initial conversion to ExceptT.
|
Alright, this looks good. Thanks for taking the time write up this large change. I'll put this up as |
|
Alright, so the remaining work is that I need to get as many downstream packages to add an |
|
Alright, so I will upload this to Hackage next weekend. Most downstream packages have either added an upper bound or have been given sufficient notice (warnings, pull requests, reminders to upload to Hackage, etc.). |
|
Alright, this is up on Hackage |
Supporting issue #32.
I provisionally renamed
throwE,catchE,handleE, andflipEtothrowEither,catchEither,handleEither, andflipEitherbecausethrowEandcatchEexist inControl.Monad.Trans.Except. I also removedthrowTandcatchTbecause of that and instead renamedhandleTtohandleE.