Replace spawn with spawn' and stop relying on GC tricks #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is definitely the right direction. |
|
Thanks, I'll keep you updated :) |
|
I got a bit distracted with other things, I'll work on this later during the week/weekend. |
|
Are there still any problem with this PR? Can it be merged after being rebased? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Gabriel439 just so you know, I started working on this. I am still working on the documentation, but I'd like you to take a look at this and check whether I am going in the right direction.
I'll continue to add documentation between today and tomorrow.
I'll open a different issue later talking a bit about some concerns I have with the type of
withSpawn, but for now I'll continue to assume its current type.