Fix space leak in Shells
#381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #380 The issue was that all of the `Shell` utilities were internally using `translate` which was inadvertently using a non-strict `Maybe` accumulator. Switching to a strict accumulator fixes the problem. This leak was introduced in version 1.5.0
Closed
|
I tested this by hand using the following program: import qualified Control.Foldl as Foldl
import qualified Turtle
main :: IO ()
main = do
x <- Turtle.fold (Turtle.select [(1::Int)..100000000]) Foldl.sum
print xBefore this change it leaked, but after this change it runs in constant space:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380
The issue was that all of the
Shellutilities were internally usingtranslatewhich was inadvertently using a non-strictMaybeaccumulator. Switching to a strict accumulator fixes the problem.
This leak was introduced in version 1.5.0