Add window icon on non-Windows platform #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the icon is set only on Windows so I fixed that using SDL. As SDL2_image fails to load the ico (certainly because it doesn't know wich image in it to load) I just used a png. If the loading fails, it will fallback to the default icon. I let you choose wether to keep this on Windows as well or not but IMO, the lesser platform-specific, the better.