New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'alias' command for querying and setting the alias #126
Conversation
Perhaps add a test or exclude the alias sub-command from coverage testing? |
I excluded all non-library files (including the client and test files) from the coverage. edit: looks like tox does not support python 3.4 anymore, so I think it's going to be dropped from testing (although it may still working on it, obviously).
|
Hmmm. I think something else changed. Travis is showing a decreese in coverage in files that are not even touched in this PR. I'd say go ahead and merge it. |
It is because this contains also a commit to only calculate coverage on the library files (e.g. ignoring the tests and the cli). The way the coverage used to be calculated was thus giving out false coverage percent, so I'm merging this now. Thanks for the review! |
…#126) * add 'alias' command for querying and setting the alias * calculate coverage only on library files, e.g., ignoring cli and test files * remove py34 and add py37 * readd py33, remove it from travis as it seems to be a travis limitation only * use xenial dist for travis, regular does not support py37..
No description provided.