Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'alias' command for querying and setting the alias #126

Merged
merged 5 commits into from Aug 13, 2018

Conversation

rytilahti
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Aug 8, 2018

Coverage Status

Coverage decreased (-7.03%) to 60.555% when pulling 1ebbf5a on rytilahti:add_alias_cmd into a6d515b on GadgetReactor:master.

@kirichkov
Copy link
Collaborator

Perhaps add a test or exclude the alias sub-command from coverage testing?

@rytilahti
Copy link
Collaborator Author

rytilahti commented Aug 10, 2018

I excluded all non-library files (including the client and test files) from the coverage.

edit: looks like tox does not support python 3.4 anymore, so I think it's going to be dropped from testing (although it may still working on it, obviously).

Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.3.6/bin/tox", line 7, in <module>
    from tox import cmdline
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/tox/__init__.py", line 10, in <module>
    from pkg_resources import DistributionNotFound, get_distribution
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/pkg_resources/__init__.py", line 85, in <module>
    raise RuntimeError("Python 3.4 or later is required")
RuntimeError: Python 3.4 or later is required

@kirichkov
Copy link
Collaborator

kirichkov commented Aug 13, 2018

Hmmm. I think something else changed. Travis is showing a decreese in coverage in files that are not even touched in this PR.

I'd say go ahead and merge it.

@rytilahti
Copy link
Collaborator Author

It is because this contains also a commit to only calculate coverage on the library files (e.g. ignoring the tests and the cli). The way the coverage used to be calculated was thus giving out false coverage percent, so I'm merging this now. Thanks for the review!

@rytilahti rytilahti merged commit ab103c3 into GadgetReactor:master Aug 13, 2018
@rytilahti rytilahti deleted the add_alias_cmd branch August 13, 2018 18:37
rytilahti added a commit to rytilahti/pyHS100 that referenced this pull request Jun 9, 2019
…#126)

* add 'alias' command for querying and setting the alias

* calculate coverage only on library files, e.g., ignoring cli and test files

* remove py34 and add py37

* readd py33, remove it from travis as it seems to be a travis limitation only

* use xenial dist for travis, regular does not support py37..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants