Merge pull request #3333 from mattigruener/metadataIssue

Metadata Lookup Issue
GafferHQ · Aug 20, 2019 · 3e5b667 · 3e5b667
2 parents 9fb5302 + d2a3aad
commit 3e5b667
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/python/GafferArnoldUI/ArnoldShaderUI.py b/python/GafferArnoldUI/ArnoldShaderUI.py
@@ -283,8 +283,9 @@ def __translateNodeMetadata( nodeEntry ) :
 			userDefault = __aiMetadataGetStr( nodeEntry, paramName, "gaffer.userDefault" )
 
 		if userDefault:
-			__metadata[paramPath]["userDefault"] = userDefault
-
+			nodeName, _, plugName = paramPath.split( "." )
+			Gaffer.Metadata.registerValue( "ai:surface:%s:%s" % ( nodeName, plugName ), "userDefault", userDefault )
+
 
 with IECoreArnold.UniverseBlock( writable = False ) :
 

diff --git a/python/GafferArnoldUITest/ArnoldShaderUITest.py b/python/GafferArnoldUITest/ArnoldShaderUITest.py
@@ -189,7 +189,16 @@ def testUserDefaultMetadata( self ) :
 		self.assertEqual( parms["uvcoords"].value, imath.V2f( 12, 13 ) )
 		self.assertEqual( parms["filename"].value, "overrideUserDefault" )
 		self.assertEqual( parms["filter"].value, "bilinear" )
-
+
+	def testBaseClassMetadataLookup( self ) :
+
+		surface = GafferArnold.ArnoldShader()
+		surface.loadShader( "standard_surface" )
+
+		# Make sure that metadata registration based on mechanism in GafferScene.ShaderUI works
+		Gaffer.Metadata.registerValue( "ai:surface:standard_surface:aov_id1", "userDefault", "id_1" )
+
+		self.assertEqual( Gaffer.Metadata.value( surface["parameters"]["aov_id1"], "userDefault" ), "id_1" )
 
 if __name__ == "__main__":
 	unittest.main()