-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault with inaccessible custom node #2319
Comments
Oh, this is with the prebuilt version 0.40.0 binaries on Linux |
johnhaddon
added a commit
to johnhaddon/gaffer
that referenced
this issue
Nov 3, 2017
Classes that didn't exist in any module were creating an empty `import` statement, which was the trigger for the crash described in GafferHQ#2319.
Thanks for the report, and glad you've got things working. I've fixed the crash in PR #2320 so you'll now get a slightly more informative error - |
Thanks! That error looks far more descriptive \o/ |
andrewkaufman
pushed a commit
to andrewkaufman/gaffer
that referenced
this issue
Feb 16, 2018
If parsing fails, a null module is returned, so we must check for it. Fixes GafferHQ#2319.
andrewkaufman
pushed a commit
to andrewkaufman/gaffer
that referenced
this issue
Feb 16, 2018
Classes that didn't exist in any module were creating an empty `import` statement, which was the trigger for the crash described in GafferHQ#2319.
andrewkaufman
pushed a commit
to andrewkaufman/gaffer
that referenced
this issue
Feb 21, 2018
If parsing fails, a null module is returned, so we must check for it. Fixes GafferHQ#2319.
andrewkaufman
pushed a commit
to andrewkaufman/gaffer
that referenced
this issue
Feb 21, 2018
Classes that didn't exist in any module were creating an empty `import` statement, which was the trigger for the crash described in GafferHQ#2319.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I create a custom node, and register it like this:
(just started looking into Gaffer and shoved it in
~/gaffer/startup/gui/example.py
as the most obvious place to get code to run)This works fine when I create the node by calling
TestInput()
directly (like by clicking the menu item)However if the node is created "indirectly" (either by saving the node into a
.gfr
script and loading it, or copypasting the node), the GUI will segfault:Fix was for me to be less lazy and define the module in a importable Python module, and specify the full path in
typeName
, e.g define it inblah.py
somewhere and do:This fixes the problem, but I'd expect a better error in the first case
The text was updated successfully, but these errors were encountered: