ExpressionUI : Fix initial UI state #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an Expression node is made directly via the Node menu, it starts out without either the expression or language set. If you entered an expression _before_ choosing the language, then this would do nothing, and then when choosing the language you'd lose the expression! I presume this hasn't been spotted until now because most people create expressions via the NodeEditor right click menu which sets the language upfront. The fix applied here is simple : if the language isn't set, label the menu to prompt the user to set it, and don't enabled the expression text field until that is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an Expression node is made directly via the Node menu, it starts out without either the expression or language set. If you entered an expression before choosing the language, then this would do nothing, and then when choosing the language you'd lose the expression! I presume this hasn't been spotted until now because most people create expressions via the NodeEditor right click menu which sets the language upfront.
The fix applied here is simple : if the language isn't set, label the menu to prompt the user to set it, and don't enabled the expression text field until that is done.