Loop refactor #2887
Merged
Loop refactor #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings it into line with Switch, Dot, TimeWarp etc.
A config file maintains compatibility with old scripts.
A compatibility config maintains compatibility for old scripts.
This was always broken, even for the old SceneLoop and ImageLoop nodes.
|
Travis won't let me restart the failed test for some reason... Any chance you want to add a shiny |
Otherwise it's a bit fiddly to make the dots manually and get the nodules on the right edges. The resulting layout is a little, shall we say, jaunty, but I'd like to leave that as a future improvement for StandardGraphLayout. We could force the node positions to what we think they should be, but then we're missing the collision detection that StandardGraphLayout performance, and we're vulnerable to any changes in size/location of NodeGadgets and nodules.
Done in 628bffc. I've also pushed two more commits with minor fixes/enhancements. |
|
Jaunty dots! I'm not even going to download and test first. Lets just merge and be surprised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on from #2880 and #2812, refactoring Loop from being a funky templated "mixin" class, into being a more straightforward single generic node.