Arnold renderer : Don't instance curves with min_pixel_width != 0
#3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Oh, I see that while the code itself looks good, there is a test for instancing that needs updating. |
Because pixel width is a screen space metric, it is not compatible with instancing, and results in this warning from Arnold : ``` 1: [curves] %s: pixel-width optimization is not compatible with instancing; disabling optimization ```
johnhaddon
force-pushed
the
arnoldCurveInstancing
branch
from
0341e9f
to
c76c62a
Compare
|
Updated the tests to account for the new behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because pixel width is a screen space metric, it is not compatible with instancing, and results in this warning from Arnold :