-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ganging of child plugs on compound plugs (e.g. colours) #402
Comments
Sounds very reasonable. The easiest approach is to stick in a right-click "Gang" menu option (or a little button) which just connects the r into the g and b plugs so they're still visible in the ui but they're non-editable and driven by the first one. Another approach would be to have a little button that just hides the g and b plugs and then have the field for r set all three values at once - that's a bit trickier, particularly as some other event (scripting or use of a non-ganged editor) could break the values apart behind the back of the ganged editor. So I would prefer the former one in that it's more explicit about what is happening and less prone to problems down the line...it's also very quick to implement if you wanted to add it to the milestone. |
First sounds fine (for now at least) |
I'll do the first one then - probably tomorrow as I'm fighting spline plugs at the mo'. It'd be doable to initiate a drag from a child plug (rather than just the label as you can now) if we can somehow resolve the conflicting requirements for all the drags that might start in one, which currently are :
And of course do all that without resorting to middle mouse button which doesn't exist on the Mac. |
Is "Gang" an official term that I'm not familiar with? If not, can we pick a term that sounds logical in all major flavors of English? Connect/Drive Siblings? |
I believe 'gang' comes from audio mixing panels. |
I presume you means flavours of English? :) Gang was a term that made sense to me, and I prefer it to talk of siblings which I suspect isn't that intuitive without some knowledge of the plug hierarchy. I'm happy to go with the consensus though if there is one... |
Sounds like Ben had some real ganging experience, so we can stick with that. I did initially write flavours just for you, but I couldn't stand the squiggly red lines indicating my egregious mistake. |
This is provided at the API level by new methods on the CompoundNumericPlug. It is then made available to the user on the popup menu on plug fields, and via a Ctrl-G shortcut when the cursor is in a plug field. Fixes GafferHQ#402.
In graffer I find my self processing a lot of float patterns/images that are actually colours.
When using the processing nodes (grade, etc) I have to set the r,g, and b plugs of any control to the same value manually, otherwise the greyscale pattern gets 'tinted'.
The more I've been doing this kind of work, the more annoying that seems.
Another option is to place a shuffle node down and remap to r,r,r - but I'd rather avoid node bloat.
Thoughts?
The text was updated successfully, but these errors were encountered: