Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arnold IPR Crop Region improvement #4267

Closed
andrewkaufman opened this issue Jun 16, 2021 · 1 comment
Closed

Arnold IPR Crop Region improvement #4267

andrewkaufman opened this issue Jun 16, 2021 · 1 comment
Labels
arnold Issues related to Gaffer's Arnold integration

Comments

@andrewkaufman
Copy link
Contributor

Summary

When adjusting the crop region box in an Arnold IPR, it currently appears to start a new render by making a new entry in the catalogue. I would prefer if the crop tool instead updates the render region for the current render / catalogue entry.

Implementation notes

@johnhaddon says

Arnold is always opening new drivers for each new progressive pass, and we have logic to ignore that and reuse the ones we have. But we currently do have to make a new one when the crop changes because the data window is baked into our drivers. Should be fixable.

@andrewkaufman andrewkaufman added the arnold Issues related to Gaffer's Arnold integration label Jun 16, 2021
@johnhaddon
Copy link
Member

Relevant code is here : https://github.com/ImageEngine/cortex/blob/master/contrib/IECoreArnold/src/IECoreArnold/outputDriver/OutputDriver.cpp#L210-L220. The problem is that the display and data window are fixed at the point we construct the IECore::DisplayDriver. We'll need some new API to change them after the fact - probably will have to be for Cortex 10.3. Might be a good idea if we allowed changing of the display window at the same time.

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Nov 7, 2023
This stops the Catalogue from thinking the render has completed in cases where Arnold has to close all drivers before opening new ones.

Fixes GafferHQ#4633.
Fixes GafferHQ#4267.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arnold Issues related to Gaffer's Arnold integration
Projects
Archived in project
Development

No branches or pull requests

2 participants