Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotkey to move all child nodes when moving a node in the NodeGraph #437

Closed
bentoogood opened this issue Jul 25, 2013 · 3 comments · Fixed by #577
Closed

Add hotkey to move all child nodes when moving a node in the NodeGraph #437

bentoogood opened this issue Jul 25, 2013 · 3 comments · Fixed by #577

Comments

@bentoogood
Copy link
Contributor

Yuta has expressed interest in being able to quickly move all the nodes upstream of the selected node by holding some hotkey.

Here's a mock up of the behaviour:
childmove

This can be helpful when shuffling branches of a shader network around to make space.

@danieldresser
Copy link
Collaborator

Instead of holding a hotkey during dragging, could it just be a hotkey you press to select all upstream nodes of the current node? Then you just tap the key to get a selection, and then you can move it, or delete it, or duplicate it.

Also, for most of these cases, you probably wouldn't want all upstream nodes - you'd just want all upstream nodes that aren't upstream of anything outside the subtree you're selecting. ( ie. if iePrimVar2 was connected to ieCheckerBoard1, then we usually wouldn't want to select it.

@bentoogood
Copy link
Contributor Author

( ie. if iePrimVar2 was connected to ieCheckerBoard1, then we usually wouldn't want to select it.

Disagree - in the original use case the user would want to move iePrimVar2 even if it was connected to ieCheckerBoard1

@johnhaddon
Copy link
Member

I'm with Ben on the interpretation of upstreamness. And I think there's a good case for a "Select Upstream Nodes" menu item (there are similar items already in the Edit menu) regardless of whether or not we do this one.

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Oct 3, 2013
Alt+Shift click adds all upstream nodes to the selection. Alt+Ctrl click removes all upstream nodes from the selection. Alt click alone remains the domain of the ViewportGadget camera controller, but the ViewportGadget now passes through Alt+Something presses, not using them for camera motion any more.

Also added GraphGadget::upstreamNodeGadgets() public method which is likely to be handy in the future, and was necessary for implementing this.

Fixes GafferHQ#437.
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Oct 3, 2013
Alt+Shift click adds all upstream nodes to the selection. Alt+Ctrl click removes all upstream nodes from the selection. Alt click alone remains the domain of the ViewportGadget camera controller, but the ViewportGadget now passes through Alt+Something presses, not using them for camera motion any more.

Also added GraphGadget::upstreamNodeGadgets() public method which is likely to be handy in the future, and was necessary for implementing this.

Fixes GafferHQ#437.
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Oct 3, 2013
Alt+Shift click adds all upstream nodes to the selection. Alt+Ctrl click removes all upstream nodes from the selection. Alt click alone remains the domain of the ViewportGadget camera controller, but the ViewportGadget now passes through Alt+Something presses, not using them for camera motion any more.

Also added GraphGadget::upstreamNodeGadgets() public method which is likely to be handy in the future, and was necessary for implementing this.

Fixes GafferHQ#437.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants