Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaffer Crashes When Resizing SpreadSheet Column Width #5296

Closed
sshrestha-fractal opened this issue May 10, 2023 · 1 comment
Closed

Gaffer Crashes When Resizing SpreadSheet Column Width #5296

sshrestha-fractal opened this issue May 10, 2023 · 1 comment

Comments

@sshrestha-fractal
Copy link

Version: Gaffer 1.2.1.1-windows
Third-party tools: Arnold
Third-party modules: Deadline

Description

When resizing a column width on a spreadsheet, gaffer sometimes crashes. This is not always reproducible and I have not been able to pin-point the exact sequence of events or the conditions for reproducing this crash. Could be a windows only issue. Initially reported on this thread.

Steps to reproduce

  1. Create a spreadsheet connected to any parameter.
  2. Resize one of the columns by dragging the column edge.
  3. Gaffer hangs for a bit and then crashes.

Debug log

Click to Expand


Traceback (most recent call last):
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\GafferUI\SpreadsheetUI\_LinkedScrollBar.py", line 127, in sliderChange
    if change == self.SliderStepsChange :
RecursionError: maximum recursion depth exceeded in comparison
Fatal Python error: Cannot recover from stack overflow.

Thread 0x00009138 (most recent call first):
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\GafferSceneUI\_SceneViewInspector.py", line 322 in _backgroundUpdate
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\GafferSceneUI\_SceneViewInspector.py", line 207 in __backgroundUpdate
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\GafferUI\BackgroundMethod.py", line 126 in backgroundFunction

Thread 0x00000c2c (most recent call first):
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\lib\threading.py", line 300 in wait
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\lib\threading.py", line 552 in wait
  File "C:\Users\sshrestha\AppData\Roaming\Shotgun\foopicture\p353c133.basic.desktop\cfg\install\core\python\tank\util\metrics.py", line 449 in run
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\lib\threading.py", line 926 in _bootstrap_inner
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\lib\threading.py", line 890 in _bootstrap

Current thread 0x00004a48 (most recent call first):
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\GafferUI\SpreadsheetUI\_LinkedScrollBar.py", line 102 in __rangeChanged
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\Gaffer\WeakMethod.py", line 65 in __call__
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\GafferUI\SpreadsheetUI\_LinkedScrollBar.py", line 102 in __rangeChanged
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\Gaffer\WeakMethod.py", line 65 in __call__
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\GafferUI\SpreadsheetUI\_PlugTableView.py", line 1276 in event
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\GafferUI\Widget.py", line 232 in setVisible
  File "C:\foo\packages\gaffer\1.2.1.1\platform-windows\python\GafferUI\SpreadsheetUI\_LinkedScrollBar.py", line 104 in __rangeChanged

ericmehl added a commit to ericmehl/gaffer that referenced this issue Oct 19, 2023
@ericmehl
_LinkedScrollBar : Guard against recursive updates
8ae09be 
This may fix GafferHQ#5296 - though I haven't been able to reproduce it. The
problem appears to be endless recursion of `sliderChange()`, which may
have been caused by one of the two scroll bars the `LinkedScrollBar`
manages emitting a change signal that then causes the other scroll bar
to update, emitting a change signal... until the stack overflows.
@ericmehl ericmehl mentioned this issue Oct 19, 2023
Merged
4 tasks
ericmehl added a commit to ericmehl/gaffer that referenced this issue Oct 23, 2023
@ericmehl
_LinkedScrollBar : Guard against recursive updates
d4b6571 
This may fix GafferHQ#5296 - though I haven't been able to reproduce it. The
problem appears to be endless recursion of `sliderChange()`, which may
have been caused by one of the two scroll bars the `LinkedScrollBar`
manages emitting a change signal that then causes the other scroll bar
to update, emitting a change signal... until the stack overflows.
johnhaddon pushed a commit to ericmehl/gaffer that referenced this issue Oct 24, 2023
@ericmehl @johnhaddon
_LinkedScrollBar : Guard against recursive updates
80e32aa 
This may fix GafferHQ#5296 - though I haven't been able to reproduce it. The
problem appears to be endless recursion of `sliderChange()`, which may
have been caused by one of the two scroll bars the `LinkedScrollBar`
manages emitting a change signal that then causes the other scroll bar
to update, emitting a change signal... until the stack overflows.
@johnhaddon
Copy link
Member

Closing, since we think this is likely fixed by #5507 (although we haven't been able to reproduce the crash here at all). Please reopen if you still see crashes in 1.3.6+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnhaddon @sshrestha-fractal