Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up/Down Arrow Within Value Fields Resets to End When Keyframe Added #5335

Closed
LinasBeres opened this issue Jun 6, 2023 · 1 comment
Closed

Up/Down Arrow Within Value Fields Resets to End When Keyframe Added #5335

LinasBeres opened this issue Jun 6, 2023 · 1 comment

Comments

@LinasBeres
Copy link

Version: Gaffer 1.2.7.0-linux
Third-party tools: None
Third-party modules: None

Description

It appears as if the up/down arrow functionality to adjust values in different input fields is currently broken if one sets a keyframe.

Upon pressing up/down arrow, the cursor/input location will be flung to the end of the value.

This stops artists from using the up/down arrow functionality on numerical values if a keyframe is added since the cursor will always jump to the end.

Steps to reproduce

  1. Create a node with a numeric value, e.g. OSL/Surface/Constant
  2. Add Set Key to the numeric value
  3. Type any number in or just leave empty
  4. Press up arrow key from the middle and the cursor will jump to the end.
@murraystevenson
Copy link
Contributor

There's another "jump to the end" behaviour when the number of integer digits decrease on the plug. It'd be worthwhile addressing this at the same time.

  1. Set a FloatPlug to a value of 110
  2. Position the cursor between the first and second digits and press the down arrow to change value to 100
  3. Press the down arrow again to change value to 90
  4. The cursor will jump to the end, so pressing the down arrow will change value to 89.9 rather than 80

ericmehl added a commit to ericmehl/gaffer that referenced this issue Jun 28, 2023
@ericmehl
NumericPlugValueWidget : Fix animated value change
57dd8a4 
Previously, incrementing an animated numeric plug with the keyboard
up / down keys would always reset the cursor to the end of the number.
There also were intermittent "---" values appearing in the value when
drag-changing the plug.

This seems to come from
`PlugValueWidget.__updateFromValuesInBackgroundPreCall()` where the
value is set to `[]` before setting the real value.

Fixes GafferHQ#5335
@ericmehl ericmehl mentioned this issue Jun 28, 2023
Merged
4 tasks
ericmehl added a commit to ericmehl/gaffer that referenced this issue Jul 5, 2023
@ericmehl
NumericPlugValueWidget : Fix animated value change
26f1ff8 
Previously, incrementing an animated numeric plug with the keyboard
up / down keys would always reset the cursor to the end of the number.
There also were intermittent "---" values appearing in the value when
drag-changing the plug.

This seems to come from
`PlugValueWidget.__updateFromValuesInBackgroundPreCall()` where the
value is set to `[]` before setting the real value.

Fixes GafferHQ#5335
ericmehl added a commit to ericmehl/gaffer that referenced this issue Jul 6, 2023
@ericmehl
NumericPlugValueWidget : Fix animated value change
c94444c 
Previously, incrementing an animated numeric plug with the keyboard
up / down keys would always reset the cursor to the end of the number.
There also were intermittent "---" values appearing in the value when
drag-changing the plug.

This seems to come from
`PlugValueWidget.__updateFromValuesInBackgroundPreCall()` where the
value is set to `[]` before setting the real value.

Fixes GafferHQ#5335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LinasBeres @murraystevenson