FileMenu : Fix premature exit when opening backup containing error #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurred when opening a file with `gaffer somefile.gfr`, and the sequence of operations was this : - Find backup, prompt to open it (in FileMenu.__addScript) - Delete prompt dialogue - QApplication decides it should quit, because the last top level window has been closed - Load script and attempt to display error dialogue, but this closes immediately because the modal event loop returns immediately - Application closes This is fixed by not deleting the dialogue until exit from the function, and merely hiding it instead. An alternative would be to call `QApplication.setQuitOnLastWindowClosed( False )`, but that might affect existing applications. Fixes GafferHQ#2526
|
I tested this OK on Linux so I'm removing the pr-onHold label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurred when opening a file with
gaffer somefile.gfr, and the sequence of operations was this :has been closed
closes immediately because the modal event loop returns
immediately
This is fixed by not deleting the dialogue until exit from the function, and merely hiding it instead. An alternative would be to call
QApplication.setQuitOnLastWindowClosed( False ), but that might affect existing applications.Fixes #2526
Note : Implemented and tested on MacOS - need to test on Linux before merging.