Viewer : Support Arnold shader networks attached to gobos #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themissingcow
force-pushed
the
goboVisualiserOSL
branch
from
4383662
to
b74efe7
Compare
themissingcow
force-pushed
the
goboVisualiserOSL
branch
from
d457e9a
to
5809bd1
Compare
johnhaddon
requested changes
Mar 11, 2020
|
Thanks Tom! LGTM. Could you squash in your fixups and update Changes.md please? |
johnhaddon
approved these changes
Mar 17, 2020
themissingcow
force-pushed
the
goboVisualiserOSL
branch
2 times, most recently
from
bdc234e
to
0bc92a4
Compare
johnhaddon
reviewed
Mar 17, 2020
We need to use the Arnold to OSL network conversion in various visualisers. As most are totally private and have no headers, moving to a private helper seemed easier than allowing other visualisers to befriend ArnoldLightVisualiser.
Improvements ------------ - Viewer : Added (limited) support for the visualisation of Arnold shader networks attached to the gobo light filter.
We now list the un-convertible shader names.
It's not helpful to return a mixed network, return nullptr instead.
themissingcow
force-pushed
the
goboVisualiserOSL
branch
from
0bc92a4
to
e768d26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Arnold shader networks attached to Gobo light filters.
In order to re-use the network conversion previously used in
ArnoldLightVisualiser, it splits this out intoGafferArnoldUI/Private/VisualiserAlgo.h.Took the opportunity to clean up messaging and error case handling a little.