TweakPlug : Fix CreateIfMissing behaviour when fallback values are provided
#5865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around issues with CreateIfMissing mode where the fallback value would mask missing values and no tweak would be created as nothing would be considered missing.
murraystevenson
force-pushed
the
tweaksFallback
branch
from
db87ba8
to
8925725
Compare
|
Thanks for the update Murray. Looks like we're missing an update to Changes.md though - I think that should mention both the fix and the API change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the issue noticed yesterday on
mainwith the AttributeTweaksCreateIfMissingmode where the recently added fallback value for "linkedLights" would prevent attributes from being created.