Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderPassEditor : Add Select Affected Objects to context menu #5899

Conversation

murraystevenson
Copy link
Contributor

This adds Select Affected Objects to the Render Pass Editor's context menu, using the various "ui:scene:acceptsSet[Name,Names,Expression]" metadata to define whether the action is enabled for an option. Might also be nice to extend support for options that contain paths, such as render:camera...

@murraystevenson murraystevenson self-assigned this Jun 14, 2024
Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Murray - another handy addition! Comments/suggestions inline as usual...

python/GafferSceneUI/RenderPassEditor.py Outdated Show resolved Hide resolved
python/GafferSceneUI/RenderPassEditor.py Show resolved Hide resolved
python/GafferSceneUI/RenderPassEditor.py Outdated Show resolved Hide resolved
Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you squash and merge please Murray?

@murraystevenson murraystevenson merged commit 2dbb2ed into GafferHQ:1.4_maintenance Jun 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants