SceneEditor : Add new base class for GafferSceneUI editors #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current thinking is that we don't need a SceneListingWidget and that most of the shared logic should be in PathColumns and Inspectors.
And add `settings()` method to provide access to the settings for all. This standardises the way we store settings for all editors, and removes some annoyances like having to pass a ScriptNode to the Settings constructor.
This was a workaround for the fact that we couldn't perform cancellation when we didn't have an input (because we couldn't find the ScriptNode), but the `Editor.Settings` node now takes care of that for us.
And an unused variable.
Pleasingly, this fixes `Unable to find ScriptNode for UVView` that could occur when we disconnected the UVView's input in `_updateFromSet()`. Now when we're not connected to anything external, we're still connected to `settings()["in"]`, which the BackgroundTask machinery can recover a ScriptNode from.
We use the `exists` plug during the update, so we need to update when it is dirtied.
murraystevenson
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us remove all the duplicated (and subtly different) boilerplate for finding the ScenePlugs to view, and fix some bugs along the way.