[Feature]: Added feature to write serial data using web serial API #42
Conversation
Witty-Wizard
added
enhancement 🪄
There was a problem hiding this comment.
HI!, @masterboy376 , Can you test if this function works. For that :
- Go to testing/tester.py
- In tester.py file add a function that listens for data and prints it.
- and for sending data send some dummy data for now.
- once you have made these changes, I will test these changes on actual hardware and if they pass I will merge this PR
@Witty-Wizard done |
|
@Witty-Wizard PTAL |
| // It writes data from the serial port and dispatches it to the redux store | ||
| export async function writeData(writer, isConnected, port, dataToWrite) { | ||
| // While the port is connected and writable | ||
| while (isConnected && port.writable) { |
There was a problem hiding this comment.
In this line don't use a while loop as that will continue to send the same data,instead use an if statement
if (isConnected && port.writable)
There was a problem hiding this comment.
@masterboy376, please look into this
There was a problem hiding this comment.
For testing this on your system there is a tool com0com please try running the script on that, I am getting an error that access is denied. This is an issue related to multiprocessing module and how it handles serial communication.
|
This PR do the following:
writeDatafunction toSerial.js file which can be used to write serial data to the connect devices.Connectfunction to initialize write whenever any new connection is established.Disconnectfunction to release writer's lock and clear it from the state.