Skip to content

Commit

Permalink
BUGFIX: re adding feature flag after deleting
Browse files Browse the repository at this point in the history
  • Loading branch information
GalDayan committed Nov 21, 2020
1 parent f32ada8 commit bf9b019
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion posthog/api/feature_flag.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ def create(self, validated_data: Dict, *args: Any, **kwargs: Any) -> FeatureFlag
try:
feature_flag = super().create(validated_data)
except IntegrityError:
raise serializers.ValidationError("This key already exists.", code="key-exists")
if self.perform_destroy(validated_data["key"]):
feature_flag = super().create(validated_data)
else:
raise serializers.ValidationError("This key already exists.", code="key-exists")

return feature_flag

Expand All @@ -56,6 +59,15 @@ def update(self, instance: FeatureFlag, validated_data: Dict, *args: Any, **kwar
except IntegrityError:
raise serializers.ValidationError("This key already exists.", code="key-exists")

def perform_destroy(self, key: str) -> bool:
featureFlag = FeatureFlag.objects.all().filter(deleted=True, key=key).first()

if featureFlag:
featureFlag.delete()
return True

return False


class FeatureFlagViewSet(AnalyticsDestroyModelMixin, viewsets.ModelViewSet):
queryset = FeatureFlag.objects.all()
Expand Down

0 comments on commit bf9b019

Please sign in to comment.