Test branch 2 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(taxonomic-filter): add api mock functions
* chore: remove makeApi from storybook preview.js
* feat(correlation): add multiselect for property names
Previously we had a simple text input box that was splitting the input
to get a list of property names. This doesn't give the greatest user
experience.
Now we have a simple select box that includes:
1. search filtering for options
2. multiselecting options
3. a select $all, although this is pretty poorly implemented at the
moment, for instance you can select $all, at the same time as
selecting a subset of properties.
* add a little commentary around PropertyNamesSelect
* add deps to useEffect
* ignore return type eslint issues
* just use console.log instead of actions
* remove unused import
* chore: add error condition
* chore(correlation): update styling of property select
This puts it more in line with
https://www.figma.com/file/gQBj9YnNgD8YW4nBwCVLZf/PostHog-App?node-id=4200%3A30715
* Add no search results message
* input focus border
* fix type
* use onBlur
* make checkbox checked colour change
* make query bold in no results message
* add clear
* Implement search highlighting
* fix typing
* add regex split comment
* if no property names selected, default to $all
* typo
* Add test for selection component
* Add test highlighting onChange lag and clicking outside
* click out side should depend on hide
* make sure onChange triggered on clear or select all
* Use app context in `organizationLogic` too * Add `organizationLogic.test.ts`
…nizationMembership (PostHog#6578) * query via organizationmembership rather than team__in * address feedback
* adds a search box to the toolbar featureflag list * test flakes because react is re-rendering between the get and the click. add an assertion to try and slow cypress down to avoid this * move filtering toolbar feature flags to a Set and out of CSS * support initKeaTestLogic() with no args * fix query-selector-all-deep jest bug * add simple test case for feature flags logic * combine selectors * with more understanding of Fuse * add simple test for flag filtering Co-authored-by: Marius Andra <marius.andra@gmail.com>
At the moment we're just running tests on pull requests. The immediate reason I'm making this change is to ensure we are producing a code coverage report for master, which allows us to produce a patch difference of coverage. Sidenote: I'm also hoping will also trigger annotations to start being added to PRs highlighting untested code, which I thought should have started with PostHog#6082
…#6585) Previously we were just running on PRs. In PostHog#6579 we also run on master. As a result we need to checkout the repo as well.
…ostHog#6576) I haven't made any attept here to resolve anything here, just to explicitly acknowledge that these are issues that eslint has highlighted and we should ignore, for the sake of easily picking up new issues. If these are truely problematic, then I am assuming they should have been picked up as bugs with the system. This doesn't stop someone from coming in and reviewing the code in this pr retrospectively.
* add search to toolbar actions display for PostHog#6202 * better markup and spacing * removes a console.log that snuck in
* Backend for querying persons given an event * address comments * add test
* Open modals for everything in correlation events * address comment
* Closes 6541 add step to empty funnel * added comments back * hide delete button when single step exists * use values directly in first step * Update frontend/src/scenes/insights/ActionFilter/ActionFilterRow/ActionFilterRow.tsx Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>
* fix * Make person header seem more click-able * clean up
* saved insights url sync WIP * sync filters with the url * improve trend and date filters * convert utils test to typescript * create simple object shallow diff function * only persist the difference from the default filters in the url * add tests and simplify operations * improve tests * better load checking
* Enable persons modal for properties correlation * adjust header * fix typings
…based (PostHog#6464) * Instrument legacy endpoint debugging * Add `currentTeamId` to `teamLogic` * Add logics utils * Update annotations endpoint in the frontend * Limit legacy endpoint logging to DEBUG * Fix `annotationsTableLogic` usage * Update test_annotation.py * Add `test_deleting_annotation_of_other_team_prevented` * Comment out debug code * Migrate actions-related code to project-based approach * Fix `infiniteTestLogic` * Rework approach * Remove redundant lines * Fix mixup * Fix non-logged-in scenes * Fix Python cast * Align approach to `teamLogic`-based * Fix logic tests * Clean up code * Fix stupid omission * Restore `props` in `connect`s * Fix capitalization * Fix action creation * Fix `ActionEdit` props type * Fix duplicate imports * Update infiniteListLogic.ts * Update ActionsTable.tsx * Fix link to new action in Toolbar
* smallest change to make aggregation work * use team in filter
* smallest change to make aggregation work * address comments * add snapshot * move function to groups model * update funnel snapshot * rename person_id to aggregation_target * update snapshots as well * dont support persons query mods for now * update snapshot * make array orders deterministic
* route new insight through insight router * remove comments
* Migration to use materialized columns for groups Workaround for PostHog#6422 * Use groups materialized columns in queries * Update mat column creation tests * Simplify aggregation_target_field * Fix migration * Update snapshots
…og#6915) * experiment with saving a migrations table * change flow * change names * missing var
…ostHog#6943) * Unify Insight page background/shadow/border style with rest of app * Reduce main area padding to 32px
* Fix help button alignment * remove unused button block
* fix player close button position * reduce player padding * allow recording on seek bar * remove skip inactivity toggle * style fix * update rrweb * add svg for remvoed content * add ts ignore to legacy files
Co-authored-by: Sam Winslow <sammywinslow@gmail.com>
* add window-id to ingestion * move window_id into snapshot data * Add tests * add window_id to snapshot_data only if included in the event * add window_id to session_recording_events table * revert ph-js downgrade * fix data generator * remove partition change * update window_id defaults for tests * missed one window_id default * rename migration for conflict
* add typegen with path writing support * toolbar paths * scene paths * all other paths * revert deleted comments * add two missing paths
* enable groups filtering * rerun snapshots * update team * fix tests
* Enable breakdowns * update team * clean up * run all breakdown tests, address review comments
* Log cohort recalculations on clickhouse This should help debug both cohort-related data quality issues. * Modify test query a bit
* preload chunks when loading esbuild scenes * fix TS error * fix license title * fix scene identifiers in menu * lowercase data-attr * make the events menu have the old data-attr * change var name to clarify its usage
|
PR queued successfully. Your position in queue is: 1 |
|
PR failed to merge with reason: Merge conflict |
|
PR queued successfully. Your position in queue is: 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe.
If this affects the front-end, include screenshots.
Checklist